Skip to content

Conversation

dshanske
Copy link
Collaborator

This removes webmention receiving being dependent on pings_open. It does allow for checking the presence of a webmentions_closed meta key to close webmentions. If this approach is validated, will move to figure out a UI for this.

For the sending, it moves from using the pung URLs property within the post object to a new temporary storage that will just store what was sent last time, compare it to what is being send this time, and use that to send deleted webmentions.

@dshanske dshanske requested a review from pfefferle July 22, 2024 04:18
@dshanske dshanske requested a review from pfefferle August 24, 2024 03:57
@dshanske
Copy link
Collaborator Author

@pfefferle Where are we on this one?

@pfefferle
Copy link
Owner

get_pung will now be updated, but not taken into care for Webmentions, so there might still be the possibility that we send Webmentions for URLs that were already pinged?!?

@pfefferle
Copy link
Owner

I agree that we should not care about the pingback settings, but why change the get_pung code?

@dshanske dshanske requested a review from pfefferle November 14, 2024 18:43
@dshanske
Copy link
Collaborator Author

I like that addition. If we're happy with this... then a future addition can add the UI to close Webmentions.. but it assumes activating the plugin means you want them

@pfefferle
Copy link
Owner

@dshanske this last commit adds settings to the block editor to disable Webmentions for a post.

Screenshot 2024-11-14 at 22 18 38

@pfefferle
Copy link
Owner

should it be also possible to deactivate outgoing Webmentions?

@dshanske
Copy link
Collaborator Author

should it be also possible to deactivate outgoing Webmentions?

We had someone who wanted to do that on a per post basis... but I'm not sure it is a desired feature by many

@pfefferle
Copy link
Owner

Ok, then we do that in a different PR!

@dshanske
Copy link
Collaborator Author

I thought they got removed on purpose. Must have misread

@pfefferle
Copy link
Owner

The Grunt dependencies are no longer needed... I need the other deps to work on the block-editor integration...

@dshanske
Copy link
Collaborator Author

That's my fault... confused the two

@pfefferle
Copy link
Owner

No problem :)

@dshanske
Copy link
Collaborator Author

Is this ready for merge, @pfefferle ? Want to see about some other fixes for a minor release.

@pfefferle
Copy link
Owner

I think we should add some tests, to ensure that everything still works after the merge!?!

@dshanske
Copy link
Collaborator Author

I'll see about getting some in and doing a dual platform check.

@pfefferle pfefferle merged commit 6b85a47 into main Feb 23, 2025
13 checks passed
@pfefferle pfefferle deleted the webmentionopen branch February 23, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants